Source/bindings/v8/SerializedScriptValue.cpp - Issue 23799009: Always pass v8::Isolate to v8::Number::New()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/SerializedScriptValue.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/SerializedScriptValue.cpp

diff --git a/Source/bindings/v8/SerializedScriptValue.cpp b/Source/bindings/v8/SerializedScriptValue.cpp

index 5bd079a494d3bb66472dac5707659ec7a3f59ed0..63f3f811cc392c313794bb7deba25fe91a5e8f69 100644

--- a/Source/bindings/v8/SerializedScriptValue.cpp

+++ b/Source/bindings/v8/SerializedScriptValue.cpp

@@ -1708,7 +1708,7 @@ private:

double number;

if (!doReadNumber(&number))

return false;

- *value = v8::Number::New(number);

+ *value = v8::Number::New(m_isolate, number);

return true;

}