Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Side by Side Diff: Source/bindings/v8/V8AbstractEventListener.h

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
103 { 103 {
104 return !m_listener.isEmpty(); 104 return !m_listener.isEmpty();
105 } 105 }
106 106
107 void clearListenerObject() 107 void clearListenerObject()
108 { 108 {
109 m_listener.clear(); 109 m_listener.clear();
110 } 110 }
111 111
112 virtual DOMWrapperWorld* world() const OVERRIDE FINAL { return m_world.g et(); } 112 virtual DOMWrapperWorld* world() const OVERRIDE FINAL { return m_world.g et(); }
113 v8::Isolate* isolate() const { return m_isolate; }
113 114
114 protected: 115 protected:
115 V8AbstractEventListener(bool isAttribute, PassRefPtr<DOMWrapperWorld>, v 8::Isolate*); 116 V8AbstractEventListener(bool isAttribute, PassRefPtr<DOMWrapperWorld>, v 8::Isolate*);
116 117
117 virtual void prepareListenerObject(ScriptExecutionContext*) { } 118 virtual void prepareListenerObject(ScriptExecutionContext*) { }
118 119
119 void setListenerObject(v8::Handle<v8::Object> listener); 120 void setListenerObject(v8::Handle<v8::Object> listener);
120 121
121 void invokeEventHandler(ScriptExecutionContext*, Event*, v8::Local<v8::V alue> jsEvent); 122 void invokeEventHandler(ScriptExecutionContext*, Event*, v8::Local<v8::V alue> jsEvent);
122 123
(...skipping 15 matching lines...) Expand all
138 // Indicates if this is an HTML type listener. 139 // Indicates if this is an HTML type listener.
139 bool m_isAttribute; 140 bool m_isAttribute;
140 141
141 RefPtr<DOMWrapperWorld> m_world; 142 RefPtr<DOMWrapperWorld> m_world;
142 v8::Isolate* m_isolate; 143 v8::Isolate* m_isolate;
143 }; 144 };
144 145
145 } // namespace WebCore 146 } // namespace WebCore
146 147
147 #endif // V8AbstractEventListener_h 148 #endif // V8AbstractEventListener_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/SerializedScriptValue.cpp ('k') | Source/bindings/v8/V8Binding.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698