Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(406)

Unified Diff: Source/bindings/scripts/v8_types.py

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/scripts/v8_types.py
diff --git a/Source/bindings/scripts/v8_types.py b/Source/bindings/scripts/v8_types.py
index b8c0095be93a2cc03fe18837c4d11f0455eb1d4a..2ca0a9e0b1d31a99eda64f2d8a424f15937e4053 100644
--- a/Source/bindings/scripts/v8_types.py
+++ b/Source/bindings/scripts/v8_types.py
@@ -80,11 +80,11 @@ PRIMITIVE_TYPES = set([
CPP_VALUE_TO_V8_VALUE_DICT = {
'boolean': 'v8Boolean({cpp_value}, {isolate})',
# long long and unsigned long long are not representable in ECMAScript.
- 'long long': 'v8::Number::New(static_cast<double>({cpp_value}))',
- 'unsigned long long': 'v8::Number::New(static_cast<double>({cpp_value}))',
- 'float': 'v8::Number::New({cpp_value})',
- 'double': 'v8::Number::New({cpp_value})',
- 'DOMTimeStamp': 'v8::Number::New(static_cast<double>({cpp_value}))',
+ 'long long': 'v8::Number::New({isolate}, static_cast<double>({cpp_value}))',
+ 'unsigned long long': 'v8::Number::New({isolate}, static_cast<double>({cpp_value}))',
+ 'float': 'v8::Number::New({isolate}, {cpp_value})',
+ 'double': 'v8::Number::New({isolate}, {cpp_value})',
+ 'DOMTimeStamp': 'v8::Number::New({isolate}, static_cast<double>({cpp_value}))',
'DOMString': 'v8String({cpp_value}, {isolate})',
}
CPP_VALUE_TO_V8_VALUE_ARRAY_OR_SEQUENCE_TYPE = 'v8Array({cpp_value}, {isolate})'
« no previous file with comments | « Source/bindings/scripts/deprecated_code_generator_v8.pm ('k') | Source/bindings/tests/idls/TestCallback.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698