Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: Source/bindings/v8/IDBBindingUtilities.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.cpp ('k') | Source/bindings/v8/ScriptFunctionCall.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/IDBBindingUtilities.cpp
diff --git a/Source/bindings/v8/IDBBindingUtilities.cpp b/Source/bindings/v8/IDBBindingUtilities.cpp
index 93b2217b0c09f861a41e6786842ec6c1df47c1bd..a727a96cf6d07254420cd227d5835ade4d33d0b6 100644
--- a/Source/bindings/v8/IDBBindingUtilities.cpp
+++ b/Source/bindings/v8/IDBBindingUtilities.cpp
@@ -54,7 +54,7 @@ static v8::Handle<v8::Value> idbKeyToV8Value(IDBKey* key, v8::Isolate* isolate)
ASSERT_NOT_REACHED();
return v8Undefined();
case IDBKey::NumberType:
- return v8::Number::New(key->number());
+ return v8::Number::New(isolate, key->number());
case IDBKey::StringType:
return v8String(key->string(), isolate);
case IDBKey::DateType:
@@ -138,7 +138,7 @@ static bool get(v8::Handle<v8::Value>& object, const String& keyPathElement, v8:
{
if (object->IsString() && keyPathElement == "length") {
int32_t length = v8::Handle<v8::String>::Cast(object)->Length();
- result = v8::Number::New(length);
+ result = v8::Number::New(isolate, length);
return true;
}
return object->IsObject() && getValueFrom(v8String(keyPathElement, isolate), result);
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.cpp ('k') | Source/bindings/v8/ScriptFunctionCall.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698