Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Side by Side Diff: Source/bindings/tests/results/V8TestCallback.cpp

Issue 23799009: Always pass v8::Isolate to v8::Number::New() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 This file is part of the Blink open source project. 2 This file is part of the Blink open source project.
3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY! 3 This file has been auto-generated by CodeGeneratorV8.pm. DO NOT MODIFY!
4 4
5 This library is free software; you can redistribute it and/or 5 This library is free software; you can redistribute it and/or
6 modify it under the terms of the GNU Library General Public 6 modify it under the terms of the GNU Library General Public
7 License as published by the Free Software Foundation; either 7 License as published by the Free Software Foundation; either
8 version 2 of the License, or (at your option) any later version. 8 version 2 of the License, or (at your option) any later version.
9 9
10 This library is distributed in the hope that it will be useful, 10 This library is distributed in the hope that it will be useful,
(...skipping 199 matching lines...) Expand 10 before | Expand all | Expand 10 after
210 } 210 }
211 211
212 v8::Handle<v8::Value> argv[] = { 212 v8::Handle<v8::Value> argv[] = {
213 sequenceParamHandle 213 sequenceParamHandle
214 }; 214 };
215 215
216 bool callbackReturnValue = false; 216 bool callbackReturnValue = false;
217 return !invokeCallback(m_callback.newLocal(isolate), 1, argv, callbackReturn Value, scriptExecutionContext(), isolate); 217 return !invokeCallback(m_callback.newLocal(isolate), 1, argv, callbackReturn Value, scriptExecutionContext(), isolate);
218 } 218 }
219 219
220 bool V8TestCallback::callbackWithFloat(float floatParam)
221 {
222 if (!canInvokeCallback())
223 return true;
224
225 v8::Isolate* isolate = v8::Isolate::GetCurrent();
226 v8::HandleScope handleScope(isolate);
227
228 v8::Handle<v8::Context> v8Context = toV8Context(scriptExecutionContext(), m_ world.get());
229 if (v8Context.IsEmpty())
230 return true;
231
232 v8::Context::Scope scope(v8Context);
233
234 v8::Handle<v8::Value> floatParamHandle = v8::Number::New(isolate, floatParam );
235 if (floatParamHandle.IsEmpty()) {
236 if (!isScriptControllerTerminating())
237 CRASH();
238 return true;
239 }
240
241 v8::Handle<v8::Value> argv[] = {
242 floatParamHandle
243 };
244
245 bool callbackReturnValue = false;
246 return !invokeCallback(m_callback.newLocal(isolate), 1, argv, callbackReturn Value, scriptExecutionContext(), isolate);
247 }
248
220 bool V8TestCallback::callbackWithThisArg(ScriptValue thisValue, int param) 249 bool V8TestCallback::callbackWithThisArg(ScriptValue thisValue, int param)
221 { 250 {
222 if (!canInvokeCallback()) 251 if (!canInvokeCallback())
223 return true; 252 return true;
224 253
225 v8::Isolate* isolate = v8::Isolate::GetCurrent(); 254 v8::Isolate* isolate = v8::Isolate::GetCurrent();
226 v8::HandleScope handleScope(isolate); 255 v8::HandleScope handleScope(isolate);
227 256
228 v8::Handle<v8::Context> v8Context = toV8Context(scriptExecutionContext(), m_ world.get()); 257 v8::Handle<v8::Context> v8Context = toV8Context(scriptExecutionContext(), m_ world.get());
229 if (v8Context.IsEmpty()) 258 if (v8Context.IsEmpty())
(...skipping 18 matching lines...) Expand all
248 v8::Handle<v8::Value> argv[] = { 277 v8::Handle<v8::Value> argv[] = {
249 paramHandle 278 paramHandle
250 }; 279 };
251 280
252 bool callbackReturnValue = false; 281 bool callbackReturnValue = false;
253 return !invokeCallback(m_callback.newLocal(isolate), v8::Handle<v8::Object>: :Cast(thisHandle), 1, argv, callbackReturnValue, scriptExecutionContext(), isola te); 282 return !invokeCallback(m_callback.newLocal(isolate), v8::Handle<v8::Object>: :Cast(thisHandle), 1, argv, callbackReturnValue, scriptExecutionContext(), isola te);
254 } 283 }
255 284
256 } // namespace WebCore 285 } // namespace WebCore
257 286
OLDNEW
« no previous file with comments | « Source/bindings/tests/results/V8TestCallback.h ('k') | Source/bindings/v8/IDBBindingUtilities.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698