Issue 23601032: Pass isolate to ScopedPersistent constructor

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed)

Created:
7 years, 3 months ago by do-not-use

Modified:
7 years, 3 months ago

Reviewers:
haraken

CC:
blink-reviews, dominicc+watchlist_chromium.org, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, Nate Chapin, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, kojih, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Pass isolate to ScopedPersistent constructor Pass isolate to ScopedPersistent constructor to avoid implicit call to v8::Isolate::GetCurrent(). R=haraken BUG=263412 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157822

Patch Set 1 #

Patch Set 2 : Update deprecated generator as well #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -42 lines)			Patch
M	Source/bindings/scripts/deprecated_code_generator_v8.pm	View	1	1 chunk	+1 line, -1 line	2 comments	Download
M	Source/bindings/templates/callback_interface.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/tests/results/V8TestCallback.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScheduledAction.cpp	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/ScopedPersistent.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/ScriptController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptDebugServer.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptInstance.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/ScriptInstance.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/ScriptPromiseResolverTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptState.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/ScriptValue.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/SharedPersistent.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/V8Binding.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp	View		1 chunk	+5 lines, -5 lines	0 comments	Download
M	Source/bindings/v8/V8MutationCallback.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/bindings/v8/V8NodeFilterCondition.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/bindings/v8/V8NodeFilterCondition.cpp	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/bindings/v8/custom/V8PromiseCustom.cpp	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	Source/core/inspector/JavaScriptCallFrame.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/inspector/JavaScriptCallFrame.cpp	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	Source/core/testing/GCObservation.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

haraken

LGTM https://codereview.chromium.org/23601032/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm File Source/bindings/scripts/deprecated_code_generator_v8.pm (right): https://codereview.chromium.org/23601032/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm#newcode4599 Source/bindings/scripts/deprecated_code_generator_v8.pm:4599: , m_callback(isolateForScriptExecutionContext(context), callback) Didn't we rename this to ...

7 years, 3 months ago (2013-09-16 12:01:27 UTC) #2

do-not-use

https://codereview.chromium.org/23601032/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm File Source/bindings/scripts/deprecated_code_generator_v8.pm (right): https://codereview.chromium.org/23601032/diff/3001/Source/bindings/scripts/deprecated_code_generator_v8.pm#newcode4599 Source/bindings/scripts/deprecated_code_generator_v8.pm:4599: , m_callback(isolateForScriptExecutionContext(context), callback) On 2013/09/16 12:01:27, haraken wrote: > ...

7 years, 3 months ago (2013-09-16 12:08:30 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23601032/3001

7 years, 3 months ago (2013-09-16 12:09:23 UTC) #4

Message was sent while issue was closed.

Change committed as 157822

Expand Messages | Collapse Messages