Source/bindings/v8/ScriptValue.h - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptValue.h

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptValue.h

diff --git a/Source/bindings/v8/ScriptValue.h b/Source/bindings/v8/ScriptValue.h

index a85a23c80df028850d1391505aa0ce072ac651b8..dc5e498f51892b51f9e8f9c6b7390e1f7df555a5 100644

--- a/Source/bindings/v8/ScriptValue.h

+++ b/Source/bindings/v8/ScriptValue.h

@@ -61,7 +61,7 @@ public:

virtual ~ScriptValue();

ScriptValue(v8::Handle<v8::Value> value)

- : m_value(value.IsEmpty() ? 0 : SharedPersistent<v8::Value>::create(value))

+ : m_value(value.IsEmpty() ? 0 : SharedPersistent<v8::Value>::create(value, v8::Isolate::GetCurrent()))

{

}