Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Unified Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp
diff --git a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp
index bb76db8880c8a47edcd6a4e71a05fa5b465ebf7a..c36727a6c5d23204a4e7c05fc4ee46040f8f8b7f 100644
--- a/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp
+++ b/Source/bindings/v8/V8CustomElementLifecycleCallbacks.cpp
@@ -91,11 +91,11 @@ V8CustomElementLifecycleCallbacks::V8CustomElementLifecycleCallbacks(ScriptExecu
: CustomElementLifecycleCallbacks(flagSet(enteredView, leftView, attributeChanged))
, ActiveDOMCallback(scriptExecutionContext)
, m_world(DOMWrapperWorld::current())
- , m_prototype(prototype)
- , m_created(created)
- , m_enteredView(enteredView)
- , m_leftView(leftView)
- , m_attributeChanged(attributeChanged)
+ , m_prototype(isolateForScriptExecutionContext(scriptExecutionContext), prototype)
+ , m_created(isolateForScriptExecutionContext(scriptExecutionContext), created)
+ , m_enteredView(isolateForScriptExecutionContext(scriptExecutionContext), enteredView)
+ , m_leftView(isolateForScriptExecutionContext(scriptExecutionContext), leftView)
+ , m_attributeChanged(isolateForScriptExecutionContext(scriptExecutionContext), attributeChanged)
, m_owner(0)
{
m_prototype.makeWeak(&m_prototype, weakCallback<v8::Object>);

Powered by Google App Engine
This is Rietveld 408576698