Source/bindings/v8/ScopedPersistent.h - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScopedPersistent.h

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScopedPersistent.h

diff --git a/Source/bindings/v8/ScopedPersistent.h b/Source/bindings/v8/ScopedPersistent.h

index faef97d9451ac5489b571cbc877a19310b130814..be41e8744ed8f2536ab381e41956a71a6da3d1a3 100644

--- a/Source/bindings/v8/ScopedPersistent.h

+++ b/Source/bindings/v8/ScopedPersistent.h

@@ -42,8 +42,8 @@ class ScopedPersistent {

public:

ScopedPersistent() { }

- explicit ScopedPersistent(v8::Handle<T> handle)

- : m_handle(v8::Isolate::GetCurrent(), handle)

+ ScopedPersistent(v8::Isolate* isolate, v8::Handle<T> handle)

+ : m_handle(isolate, handle)

{

}