Source/bindings/v8/ScriptController.cpp - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptController.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptController.cpp

diff --git a/Source/bindings/v8/ScriptController.cpp b/Source/bindings/v8/ScriptController.cpp

index 031928d25d45369d9925ab5f6ba0fedbf1f9e193..f34a5fb4816965fa746426c4ed4f470ab3eecda6 100644

--- a/Source/bindings/v8/ScriptController.cpp

+++ b/Source/bindings/v8/ScriptController.cpp

@@ -419,7 +419,7 @@ PassScriptInstance ScriptController::createScriptInstanceForWidget(Widget* widge

// Track the plugin object. We've been given a reference to the object.

m_pluginObjects.set(widget, npObject);

- return V8ScriptInstance::create(wrapper);

+ return V8ScriptInstance::create(wrapper, m_isolate);

}

void ScriptController::cleanupScriptObjectsForPlugin(Widget* nativeHandle)