Source/bindings/scripts/deprecated_code_generator_v8.pm - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/scripts/deprecated_code_generator_v8.pm

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/scripts/deprecated_code_generator_v8.pm

diff --git a/Source/bindings/scripts/deprecated_code_generator_v8.pm b/Source/bindings/scripts/deprecated_code_generator_v8.pm

index 62a75dcd97836f804f58a55b8a39e229c0da9e2f..80388538b715517f25242504f6962b4b520e8533 100644

--- a/Source/bindings/scripts/deprecated_code_generator_v8.pm

+++ b/Source/bindings/scripts/deprecated_code_generator_v8.pm

@@ -4596,7 +4596,7 @@ sub GenerateCallbackImplementation

$implementation{nameSpaceWebCore}->add(<<END);

${v8ClassName}::${v8ClassName}(v8::Handle<v8::Object> callback, ScriptExecutionContext* context)

: ActiveDOMCallback(context)

- , m_callback(callback)

+ , m_callback(isolateForScriptExecutionContext(context), callback)

haraken 2013/09/16 12:01:27 Didn't we rename this to toIsolate() ?

do-not-use 2013/09/16 12:08:30 This hasn't landed yet. I'll rebase whatever patch

, m_world(DOMWrapperWorld::current())

{

}

« no previous file with comments | « no previous file | Source/bindings/templates/callback_interface.cpp » ('j') | no next file with comments »