Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(567)

Side by Side Diff: Source/bindings/v8/ScheduledAction.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007-2009 Google Inc. All rights reserved. 2 * Copyright (C) 2007-2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 #include "core/dom/Document.h" 39 #include "core/dom/Document.h"
40 #include "core/dom/ScriptExecutionContext.h" 40 #include "core/dom/ScriptExecutionContext.h"
41 #include "core/page/Frame.h" 41 #include "core/page/Frame.h"
42 #include "core/platform/chromium/TraceEvent.h" 42 #include "core/platform/chromium/TraceEvent.h"
43 #include "core/workers/WorkerGlobalScope.h" 43 #include "core/workers/WorkerGlobalScope.h"
44 #include "core/workers/WorkerThread.h" 44 #include "core/workers/WorkerThread.h"
45 45
46 namespace WebCore { 46 namespace WebCore {
47 47
48 ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, v8::Handle<v8: :Function> function, int argc, v8::Handle<v8::Value> argv[], v8::Isolate* isolat e) 48 ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, v8::Handle<v8: :Function> function, int argc, v8::Handle<v8::Value> argv[], v8::Isolate* isolat e)
49 : m_context(context) 49 : m_context(isolate, context)
50 , m_function(function) 50 , m_function(isolate, function)
51 , m_code(String(), KURL(), TextPosition::belowRangePosition()) 51 , m_code(String(), KURL(), TextPosition::belowRangePosition())
52 , m_isolate(isolate) 52 , m_isolate(isolate)
53 { 53 {
54 m_args.reserveCapacity(argc); 54 m_args.reserveCapacity(argc);
55 for (int i = 0; i < argc; ++i) 55 for (int i = 0; i < argc; ++i)
56 m_args.append(UnsafePersistent<v8::Value>(m_isolate, argv[i])); 56 m_args.append(UnsafePersistent<v8::Value>(m_isolate, argv[i]));
57 } 57 }
58 58
59 ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, const String& code, const KURL& url, v8::Isolate* isolate) 59 ScheduledAction::ScheduledAction(v8::Handle<v8::Context> context, const String& code, const KURL& url, v8::Isolate* isolate)
60 : m_context(context) 60 : m_context(isolate, context)
61 , m_code(code, url) 61 , m_code(code, url)
62 , m_isolate(isolate) 62 , m_isolate(isolate)
63 { 63 {
64 } 64 }
65 65
66 ScheduledAction::~ScheduledAction() 66 ScheduledAction::~ScheduledAction()
67 { 67 {
68 for (size_t i = 0; i < m_args.size(); ++i) 68 for (size_t i = 0; i < m_args.size(); ++i)
69 m_args[i].dispose(); 69 m_args[i].dispose();
70 } 70 }
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 } 120 }
121 121
122 void ScheduledAction::createLocalHandlesForArgs(Vector<v8::Handle<v8::Value> >* handles) 122 void ScheduledAction::createLocalHandlesForArgs(Vector<v8::Handle<v8::Value> >* handles)
123 { 123 {
124 handles->reserveCapacity(m_args.size()); 124 handles->reserveCapacity(m_args.size());
125 for (size_t i = 0; i < m_args.size(); ++i) 125 for (size_t i = 0; i < m_args.size(); ++i)
126 handles->append(m_args[i].newLocal(m_isolate)); 126 handles->append(m_args[i].newLocal(m_isolate));
127 } 127 }
128 128
129 } // namespace WebCore 129 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698