Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: Source/bindings/v8/SharedPersistent.h

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/SharedPersistent.h
diff --git a/Source/bindings/v8/SharedPersistent.h b/Source/bindings/v8/SharedPersistent.h
index 52cc1196f348e14168c6fbaf9332d475d76e5055..011462cdcfccd6007c6d429f42698919d6811eb3 100644
--- a/Source/bindings/v8/SharedPersistent.h
+++ b/Source/bindings/v8/SharedPersistent.h
@@ -42,9 +42,9 @@ namespace WebCore {
class SharedPersistent : public RefCounted<SharedPersistent<T> > {
WTF_MAKE_NONCOPYABLE(SharedPersistent);
public:
- static PassRefPtr<SharedPersistent<T> > create(v8::Handle<T> value)
+ static PassRefPtr<SharedPersistent<T> > create(v8::Handle<T> value, v8::Isolate* isolate)
{
- return adoptRef(new SharedPersistent<T>(value));
+ return adoptRef(new SharedPersistent<T>(value, isolate));
}
v8::Local<T> newLocal(v8::Isolate* isolate) const
@@ -60,7 +60,7 @@ namespace WebCore {
}
private:
- explicit SharedPersistent(v8::Handle<T> value) : m_value(value) { }
+ explicit SharedPersistent(v8::Handle<T> value, v8::Isolate* isolate) : m_value(isolate, value) { }
ScopedPersistent<T> m_value;
};

Powered by Google App Engine
This is Rietveld 408576698