Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Side by Side Diff: Source/core/inspector/JavaScriptCallFrame.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 18 matching lines...) Expand all
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/inspector/JavaScriptCallFrame.h" 32 #include "core/inspector/JavaScriptCallFrame.h"
33 33
34 #include "bindings/v8/V8Binding.h" 34 #include "bindings/v8/V8Binding.h"
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 JavaScriptCallFrame::JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext , v8::Handle<v8::Object> callFrame) 38 JavaScriptCallFrame::JavaScriptCallFrame(v8::Handle<v8::Context> debuggerContext , v8::Handle<v8::Object> callFrame)
39 : m_debuggerContext(debuggerContext) 39 : m_isolate(v8::Isolate::GetCurrent())
40 , m_callFrame(callFrame) 40 , m_debuggerContext(m_isolate, debuggerContext)
41 , m_isolate(v8::Isolate::GetCurrent()) 41 , m_callFrame(m_isolate, callFrame)
42 { 42 {
43 ScriptWrappable::init(this); 43 ScriptWrappable::init(this);
44 } 44 }
45 45
46 JavaScriptCallFrame::~JavaScriptCallFrame() 46 JavaScriptCallFrame::~JavaScriptCallFrame()
47 { 47 {
48 } 48 }
49 49
50 JavaScriptCallFrame* JavaScriptCallFrame::caller() 50 JavaScriptCallFrame* JavaScriptCallFrame::caller()
51 { 51 {
(...skipping 99 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function> ::Cast(callFrame->Get(v8::String::NewSymbol("setVariableValue"))); 151 v8::Handle<v8::Function> setVariableValueFunction = v8::Handle<v8::Function> ::Cast(callFrame->Get(v8::String::NewSymbol("setVariableValue")));
152 v8::Handle<v8::Value> argv[] = { 152 v8::Handle<v8::Value> argv[] = {
153 v8::Handle<v8::Value>(v8::Integer::New(scopeNumber, m_isolate)), 153 v8::Handle<v8::Value>(v8::Integer::New(scopeNumber, m_isolate)),
154 v8String(variableName, m_isolate), 154 v8String(variableName, m_isolate),
155 newValue 155 newValue
156 }; 156 };
157 return setVariableValueFunction->Call(callFrame, 3, argv); 157 return setVariableValueFunction->Call(callFrame, 3, argv);
158 } 158 }
159 159
160 } // namespace WebCore 160 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698