Source/core/testing/GCObservation.cpp - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/testing/GCObservation.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/testing/GCObservation.cpp

diff --git a/Source/core/testing/GCObservation.cpp b/Source/core/testing/GCObservation.cpp

index 93176bd626391637483981f84a080da41e4d1654..90738d495bbda9dc577ad62f4f3ad7d23ca3f464 100644

--- a/Source/core/testing/GCObservation.cpp

+++ b/Source/core/testing/GCObservation.cpp

@@ -46,7 +46,7 @@ void GCObservation::setWasCollected()

}

GCObservation::GCObservation(v8::Handle<v8::Value> observedValue)

- : m_observed(observedValue)

+ : m_observed(v8::Isolate::GetCurrent(), observedValue)

, m_collected(false)

{

m_observed.makeWeak(this, makeWeakCallback);