Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.h

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8NodeFilterCondition.h
diff --git a/Source/bindings/v8/V8NodeFilterCondition.h b/Source/bindings/v8/V8NodeFilterCondition.h
index daaeb0f0d3c7d45ebe72792b9a3df1124d9061b1..2a525944db34907db9b41448b425d62709572782 100644
--- a/Source/bindings/v8/V8NodeFilterCondition.h
+++ b/Source/bindings/v8/V8NodeFilterCondition.h
@@ -60,9 +60,9 @@ class ScriptState;
// (V8)
class V8NodeFilterCondition : public NodeFilterCondition {
public:
- static PassRefPtr<V8NodeFilterCondition> create(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner)
+ static PassRefPtr<V8NodeFilterCondition> create(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner, v8::Isolate* isolate)
{
- return adoptRef(new V8NodeFilterCondition(filter, owner));
+ return adoptRef(new V8NodeFilterCondition(filter, owner, isolate));
}
virtual ~V8NodeFilterCondition();
@@ -73,7 +73,7 @@ private:
// As the value |filter| is maintained by V8GC, the |owner| which references
// V8NodeFilterCondition, usually a wrapper of NodeFilter, is specified here
// to hold a strong reference to |filter|.
- V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner);
+ V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner, v8::Isolate*);
static void makeWeakCallback(v8::Isolate*, v8::Persistent<v8::Value>*, V8NodeFilterCondition*);

Powered by Google App Engine
This is Rietveld 408576698