Source/bindings/v8/V8NodeFilterCondition.cpp - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8NodeFilterCondition.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8NodeFilterCondition.cpp

diff --git a/Source/bindings/v8/V8NodeFilterCondition.cpp b/Source/bindings/v8/V8NodeFilterCondition.cpp

index 59119531d281d3b701a6c08b2ca00c3d91cc4f4d..94fe3abf4f41367abbc7c8f52976994b59b0b278 100644

--- a/Source/bindings/v8/V8NodeFilterCondition.cpp

+++ b/Source/bindings/v8/V8NodeFilterCondition.cpp

@@ -41,8 +41,8 @@

namespace WebCore {

-V8NodeFilterCondition::V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner)

- : m_filter(filter)

+V8NodeFilterCondition::V8NodeFilterCondition(v8::Handle<v8::Value> filter, v8::Handle<v8::Object> owner, v8::Isolate* isolate)

+ : m_filter(isolate, filter)

{

owner->SetHiddenValue(V8HiddenPropertyName::condition(), filter);

m_filter.makeWeak(this, &makeWeakCallback);