Source/bindings/v8/ScriptPromiseResolverTest.cpp - Issue 23601032: Pass isolate to ScopedPersistent constructor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/ScriptPromiseResolverTest.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Update deprecated generator as well Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/ScriptPromiseResolverTest.cpp

diff --git a/Source/bindings/v8/ScriptPromiseResolverTest.cpp b/Source/bindings/v8/ScriptPromiseResolverTest.cpp

index 21fe80c7d53599ec6f722f665e0588a753005847..123815826d27faed0c46c916c3dbbb169d75d54f 100644

--- a/Source/bindings/v8/ScriptPromiseResolverTest.cpp

+++ b/Source/bindings/v8/ScriptPromiseResolverTest.cpp

@@ -47,7 +47,7 @@ public:

ScriptPromiseResolverTest()

: m_isolate(v8::Isolate::GetCurrent())

, m_handleScope(m_isolate)

- , m_context(v8::Context::New(m_isolate))

+ , m_context(m_isolate, v8::Context::New(m_isolate))

, m_contextScope(m_context.newLocal(m_isolate))

{

}