Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(385)

Side by Side Diff: Source/bindings/v8/V8Binding.cpp

Issue 23601032: Pass isolate to ScopedPersistent constructor (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Update deprecated generator as well Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
154 return result; 154 return result;
155 } 155 }
156 156
157 PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate) 157 PassRefPtr<NodeFilter> toNodeFilter(v8::Handle<v8::Value> callback, v8::Isolate* isolate)
158 { 158 {
159 RefPtr<NodeFilter> filter = NodeFilter::create(); 159 RefPtr<NodeFilter> filter = NodeFilter::create();
160 160
161 // FIXME: Should pass in appropriate creationContext 161 // FIXME: Should pass in appropriate creationContext
162 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>(); 162 v8::Handle<v8::Object> filterWrapper = toV8(filter, v8::Handle<v8::Object>() , isolate).As<v8::Object>();
163 163
164 RefPtr<NodeFilterCondition> condition = V8NodeFilterCondition::create(callba ck, filterWrapper); 164 RefPtr<NodeFilterCondition> condition = V8NodeFilterCondition::create(callba ck, filterWrapper, isolate);
165 filter->setCondition(condition.release()); 165 filter->setCondition(condition.release());
166 166
167 return filter.release(); 167 return filter.release();
168 } 168 }
169 169
170 static const int8_t kMaxInt8 = 127; 170 static const int8_t kMaxInt8 = 127;
171 static const int8_t kMinInt8 = -128; 171 static const int8_t kMinInt8 = -128;
172 static const uint8_t kMaxUInt8 = 255; 172 static const uint8_t kMaxUInt8 = 255;
173 const int32_t kMaxInt32 = 0x7fffffff; 173 const int32_t kMaxInt32 = 0x7fffffff;
174 const int32_t kMinInt32 = -kMaxInt32 - 1; 174 const int32_t kMinInt32 = -kMaxInt32 - 1;
(...skipping 426 matching lines...) Expand 10 before | Expand all | Expand 10 after
601 } 601 }
602 return v8::Isolate::GetCurrent(); 602 return v8::Isolate::GetCurrent();
603 } 603 }
604 604
605 v8::Isolate* isolateForFrame(Frame* frame) 605 v8::Isolate* isolateForFrame(Frame* frame)
606 { 606 {
607 return frame->script()->isolate(); 607 return frame->script()->isolate();
608 } 608 }
609 609
610 } // namespace WebCore 610 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698