Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2324663004: Remove unneeded GrGLSLTransformedCoordsArray type (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove unneeded GrGLSLTransformedCoordsArray type Rename GrGLSLFragmentBuilder::ensureFSCoords2D to ensureCoords2D and make it take an arbitrary GrShaderVar. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2324663004 Committed: https://skia.googlesource.com/skia/+/1a1aa9303484106a955e5549bf8ae24950f54e7a

Patch Set 1 #

Patch Set 2 : update comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+86 lines, -103 lines) Patch
M experimental/SkPerlinNoiseShader2/SkPerlinNoiseShader2.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M gm/dcshader.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M gyp/gpu.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/GrAlphaThresholdFragmentProcessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkPerlinNoiseShader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient_gpu.cpp View 5 chunks +12 lines, -10 lines 0 comments Download
M src/gpu/GrPathProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrBicubicEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrMatrixConvolutionEffect.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrSimpleTextureEffect.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrYUVEffect.cpp View 1 chunk +9 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.h View 1 4 chunks +25 lines, -19 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentProcessor.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.h View 1 3 chunks +5 lines, -6 lines 0 comments Download
M src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp View 1 chunk +8 lines, -11 lines 0 comments Download
M src/gpu/glsl/GrGLSLGeometryProcessor.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/glsl/GrGLSLPrimitiveProcessor.h View 2 chunks +1 line, -2 lines 0 comments Download
D src/gpu/glsl/GrGLSLProcessorTypes.h View 1 chunk +0 lines, -20 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
bsalomon
4 years, 3 months ago (2016-09-08 20:34:47 UTC) #3
bsalomon
ping
4 years, 3 months ago (2016-09-12 13:42:48 UTC) #4
egdaniel
lgtm
4 years, 3 months ago (2016-09-12 13:48:45 UTC) #5
commit-bot: I haz the power
This CL has an open dependency (Issue 2316413003 Patch 1). Please resolve the dependency and ...
4 years, 3 months ago (2016-09-12 14:47:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2324663004/20001
4 years, 3 months ago (2016-09-12 16:05:12 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 16:30:38 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1a1aa9303484106a955e5549bf8ae24950f54e7a

Powered by Google App Engine
This is Rietveld 408576698