Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2316413003: Remove ability to skip coord transform comparison in pipeline comparison. (Closed)

Created:
4 years, 3 months ago by bsalomon
Modified:
4 years, 3 months ago
Reviewers:
egdaniel
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove ability to skip coord transform comparison in pipeline comparison. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2316413003 Committed: https://skia.googlesource.com/skia/+/7312ff87f64f31d741989a60d993bcaa4bb20523

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -17 lines) Patch
M include/gpu/GrFragmentProcessor.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrFragmentProcessor.cpp View 2 chunks +3 lines, -8 lines 0 comments Download
M src/gpu/GrPipeline.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M src/gpu/batches/GrDrawPathBatch.cpp View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
bsalomon
This functionality isn't being used. I think ultimately we will want to ability to skip ...
4 years, 3 months ago (2016-09-08 18:41:17 UTC) #3
egdaniel
lgtm
4 years, 3 months ago (2016-09-12 13:49:22 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2316413003/1
4 years, 3 months ago (2016-09-12 14:48:06 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-12 15:55:40 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/7312ff87f64f31d741989a60d993bcaa4bb20523

Powered by Google App Engine
This is Rietveld 408576698