src/effects/gradients/SkRadialGradient.cpp - Issue 2324663004: Remove unneeded GrGLSLTransformedCoordsArray type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkRadialGradient.cpp

Issue 2324663004: Remove unneeded GrGLSLTransformedCoordsArray type (Closed)

Patch Set: update comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkRadialGradient.cpp

diff --git a/src/effects/gradients/SkRadialGradient.cpp b/src/effects/gradients/SkRadialGradient.cpp

index 78ecffae1a003b66196918dfcd3a4cc0be7f65c9..1fbd1716abad9917f07aaffa2946159b85c65c54 100644

--- a/src/effects/gradients/SkRadialGradient.cpp

+++ b/src/effects/gradients/SkRadialGradient.cpp

@@ -333,7 +333,7 @@ void GrRadialGradient::GLSLRadialProcessor::emitCode(EmitArgs& args) {

const GrRadialGradient& ge = args.fFp.cast<GrRadialGradient>();

this->emitUniforms(args.fUniformHandler, ge);

SkString t("length(");

- t.append(args.fFragBuilder->ensureFSCoords2D(args.fCoords, 0));

+ t.append(args.fFragBuilder->ensureCoords2D(args.fTransformedCoords[0]));

t.append(")");

this->emitColor(args.fFragBuilder,

args.fUniformHandler,