src/effects/SkLightingImageFilter.cpp - Issue 2324663004: Remove unneeded GrGLSLTransformedCoordsArray type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkLightingImageFilter.cpp

Issue 2324663004: Remove unneeded GrGLSLTransformedCoordsArray type (Closed)

Patch Set: update comments Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkLightingImageFilter.cpp

diff --git a/src/effects/SkLightingImageFilter.cpp b/src/effects/SkLightingImageFilter.cpp

index 5e5aca96af133fde57e62c5628eaf836eb5c6992..0c82b1655e7755584050ae489e325e9f1a6aaf08 100644

--- a/src/effects/SkLightingImageFilter.cpp

+++ b/src/effects/SkLightingImageFilter.cpp

@@ -1803,7 +1803,7 @@ void GrGLLightingEffect::emitCode(EmitArgs& args) {

GrGLSLShaderVar("scale", kFloat_GrSLType),

};

SkString sobelFuncName;

- SkString coords2D = fragBuilder->ensureFSCoords2D(args.fCoords, 0);

+ SkString coords2D = fragBuilder->ensureCoords2D(args.fTransformedCoords[0]);

fragBuilder->emitFunction(kFloat_GrSLType,

"sobel",

« no previous file with comments | « src/effects/SkDisplacementMapEffect.cpp ('k') | src/effects/SkMagnifierImageFilter.cpp » ('j') | no next file with comments »