Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Created:
4 years, 3 months ago by dcheng
Modified:
4 years, 3 months ago
Reviewers:
Devlin
CC:
chromium-reviews, extensions-reviews_chromium.org, tzik, nhiroki, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, jshin+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. BUG=581865 Committed: https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475 Cr-Commit-Position: refs/heads/master@{#418568}

Patch Set 1 #

Patch Set 2 : Add some includes #

Patch Set 3 : Less explosions #

Total comments: 14

Patch Set 4 : One more fix #

Patch Set 5 : Um #

Patch Set 6 : ... I hate C++ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -138 lines) Patch
M chrome/browser/extensions/api/commands/commands.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/debugger/debugger_api.cc View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc View 1 2 3 4 5 2 chunks +28 lines, -18 lines 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/downloads/downloads_api.cc View 1 2 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/extensions/api/font_settings/font_settings_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/preference/preference_api.cc View 1 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc View 1 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/system_private/system_private_api.cc View 1 3 chunks +10 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/tabs/app_window_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/tabs/app_window_controller.cc View 1 chunk +3 lines, -8 lines 0 comments Download
M chrome/browser/extensions/api/tabs/tabs_event_router.cc View 1 2 3 chunks +13 lines, -14 lines 0 comments Download
M chrome/browser/extensions/browser_extension_window_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/extensions/browser_extension_window_controller.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/extensions/menu_manager.cc View 1 2 3 7 chunks +18 lines, -14 lines 0 comments Download
M chrome/browser/extensions/window_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/printer_provider/printer_provider_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M extensions/browser/app_window/app_window_contents.cc View 1 2 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/computed_hashes.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/browser/event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/script_executor.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/common/event_filter_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M extensions/common/extension_l10n_util_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/common/permissions/manifest_permission.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
dcheng
https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/tabs/tabs_event_router.cc File chrome/browser/extensions/api/tabs/tabs_event_router.cc (right): https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/tabs/tabs_event_router.cc#newcode309 chrome/browser/extensions/api/tabs/tabs_event_router.cc:309: args->Append(object_args->CreateDeepCopy()); This method has slightly more substantial changes. The ...
4 years, 3 months ago (2016-09-12 18:08:55 UTC) #8
Devlin
A few places will break, since they were doing similar "pass ownership, then modify" tricks. ...
4 years, 3 months ago (2016-09-12 19:12:34 UTC) #11
dcheng
https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/commands/commands.cc File chrome/browser/extensions/api/commands/commands.cc (right): https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/commands/commands.cc#newcode18 chrome/browser/extensions/api/commands/commands.cc:18: std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue()); On 2016/09/12 19:12:34, Devlin wrote: > ...
4 years, 3 months ago (2016-09-12 20:26:46 UTC) #13
Devlin
https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc File chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc (right): https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc#newcode199 chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc:199: parameters->SetBoolean(key, false); On 2016/09/12 19:12:34, Devlin wrote: > badness ...
4 years, 3 months ago (2016-09-12 21:01:30 UTC) #15
dcheng
https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc File chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc (right): https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc#newcode199 chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc:199: parameters->SetBoolean(key, false); On 2016/09/12 21:01:30, Devlin wrote: > On ...
4 years, 3 months ago (2016-09-13 20:54:20 UTC) #20
Devlin
lgtm https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/debugger/debugger_api.cc File chrome/browser/extensions/api/debugger/debugger_api.cc (right): https://codereview.chromium.org/2323993004/diff/40001/chrome/browser/extensions/api/debugger/debugger_api.cc#newcode709 chrome/browser/extensions/api/debugger/debugger_api.cc:709: return std::move(dictionary); On 2016/09/12 20:26:45, dcheng wrote: > ...
4 years, 3 months ago (2016-09-14 14:56:53 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2323993004/100001
4 years, 3 months ago (2016-09-14 15:13:09 UTC) #25
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years, 3 months ago (2016-09-14 15:18:38 UTC) #26
commit-bot: I haz the power
4 years, 3 months ago (2016-09-14 15:20:03 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/f19502008401dc093629f3ca082f82edbc47e475
Cr-Commit-Position: refs/heads/master@{#418568}

Powered by Google App Engine
This is Rietveld 408576698