Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: chrome/browser/extensions/browser_extension_window_controller.h

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "chrome/browser/extensions/window_controller.h" 9 #include "chrome/browser/extensions/window_controller.h"
10 10
11 class Browser; 11 class Browser;
12 12
13 namespace extensions { 13 namespace extensions {
14 class Extension; 14 class Extension;
15 } 15 }
16 16
17 class BrowserExtensionWindowController : public extensions::WindowController { 17 class BrowserExtensionWindowController : public extensions::WindowController {
18 public: 18 public:
19 explicit BrowserExtensionWindowController(Browser* browser); 19 explicit BrowserExtensionWindowController(Browser* browser);
20 ~BrowserExtensionWindowController() override; 20 ~BrowserExtensionWindowController() override;
21 21
22 // extensions::WindowController implementation. 22 // extensions::WindowController implementation.
23 int GetWindowId() const override; 23 int GetWindowId() const override;
24 std::string GetWindowTypeText() const override; 24 std::string GetWindowTypeText() const override;
25 std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs( 25 std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(
26 const extensions::Extension* extension) const override; 26 const extensions::Extension* extension) const override;
27 base::DictionaryValue* CreateTabValue(const extensions::Extension* extension,
28 int tab_index) const override;
29 std::unique_ptr<extensions::api::tabs::Tab> CreateTabObject( 27 std::unique_ptr<extensions::api::tabs::Tab> CreateTabObject(
30 const extensions::Extension* extension, 28 const extensions::Extension* extension,
31 int tab_index) const override; 29 int tab_index) const override;
32 bool CanClose(Reason* reason) const override; 30 bool CanClose(Reason* reason) const override;
33 void SetFullscreenMode(bool is_fullscreen, 31 void SetFullscreenMode(bool is_fullscreen,
34 const GURL& extension_url) const override; 32 const GURL& extension_url) const override;
35 Browser* GetBrowser() const override; 33 Browser* GetBrowser() const override;
36 bool IsVisibleToExtension( 34 bool IsVisibleToExtension(
37 const extensions::Extension* extension) const override; 35 const extensions::Extension* extension) const override;
38 36
39 private: 37 private:
40 Browser* browser_; 38 Browser* browser_;
41 39
42 DISALLOW_COPY_AND_ASSIGN(BrowserExtensionWindowController); 40 DISALLOW_COPY_AND_ASSIGN(BrowserExtensionWindowController);
43 }; 41 };
44 42
45 #endif // CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_ 43 #endif // CHROME_BROWSER_EXTENSIONS_BROWSER_EXTENSION_WINDOW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698