extensions/browser/api/printer_provider/printer_provider_apitest.cc - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/printer_provider/printer_provider_apitest.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: ... I hate C++ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/networking_private/networking_private_linux.cc ('k') | extensions/browser/api/runtime/runtime_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/printer_provider/printer_provider_apitest.cc

diff --git a/extensions/browser/api/printer_provider/printer_provider_apitest.cc b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

index 3ffb44320ad060989dfac825309c81416e66993b..d0b8cb40f6525e72bbaece0d03aa4d5ad209cec4 100644

--- a/extensions/browser/api/printer_provider/printer_provider_apitest.cc

+++ b/extensions/browser/api/printer_provider/printer_provider_apitest.cc

@@ -48,7 +48,7 @@ void AppendPrintersAndRunCallbackIfDone(base::ListValue* printers_out,

EXPECT_TRUE(printers.GetDictionary(i, &printer))

<< "Found invalid printer value at index " << i << ": " << printers;

if (printer)

- printers_out->Append(printer->DeepCopy());

+ printers_out->Append(printer->CreateDeepCopy());

}

if (done && !callback.is_null())

callback.Run();