Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3683)

Unified Diff: chrome/browser/extensions/api/commands/commands.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/commands/commands.cc
diff --git a/chrome/browser/extensions/api/commands/commands.cc b/chrome/browser/extensions/api/commands/commands.cc
index eec31c29424e2eb62585ccbd9deea7beee3006ab..608d5db2dcb1939c7bc61d7c4ea3aa9419d8a12c 100644
--- a/chrome/browser/extensions/api/commands/commands.cc
+++ b/chrome/browser/extensions/api/commands/commands.cc
@@ -12,9 +12,10 @@
namespace {
-base::DictionaryValue* CreateCommandValue(
- const extensions::Command& command, bool active) {
- base::DictionaryValue* result = new base::DictionaryValue();
+std::unique_ptr<base::DictionaryValue> CreateCommandValue(
+ const extensions::Command& command,
+ bool active) {
+ std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());
result->SetString("name", command.command_name());
result->SetString("description", command.description());
result->SetString("shortcut",
« no previous file with comments | « no previous file | chrome/browser/extensions/api/debugger/debugger_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698