Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

chrome/browser/extensions/api/tabs/tabs_event_router.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/tabs/tabs_event_router.h"
 
 #include <stddef.h>
 
 #include <memory>
 #include <utility>
@@ skipping 174 matching lines @@
   }
 }
 
 static bool WillDispatchTabCreatedEvent(
     WebContents* contents,
     bool active,
     content::BrowserContext* context,
     const Extension* extension,
     Event* event,
     const base::DictionaryValue* listener_filter) {
-  base::DictionaryValue* tab_value =
-      ExtensionTabUtil::CreateTabObject(contents, extension)
-          ->ToValue()
-          .release();
   event->event_args->Clear();
-  event->event_args->Append(tab_value);
+  std::unique_ptr<base::DictionaryValue> tab_value =
+      ExtensionTabUtil::CreateTabObject(contents, extension)->ToValue();
   tab_value->SetBoolean(tabs_constants::kSelectedKey, active);
   tab_value->SetBoolean(tabs_constants::kActiveKey, active);
+  event->event_args->Append(std::move(tab_value));
   return true;
 }
 
 void TabsEventRouter::TabCreatedAt(WebContents* contents,
                                    int index,
                                    bool active) {
   Profile* profile = Profile::FromBrowserContext(contents->GetBrowserContext());
   std::unique_ptr<base::ListValue> args(new base::ListValue);
   std::unique_ptr<Event> event(new Event(
       events::TABS_ON_CREATED, tabs::OnCreated::kEventName, std::move(args)));
@@ skipping 80 matching lines @@
   DispatchEvent(profile, events::TABS_ON_REMOVED, tabs::OnRemoved::kEventName,
                 std::move(args), EventRouter::USER_GESTURE_UNKNOWN);
 
   UnregisterForTabNotifications(contents);
 }
 
 void TabsEventRouter::ActiveTabChanged(WebContents* old_contents,
                                        WebContents* new_contents,
                                        int index,
                                        int reason) {
-  std::unique_ptr<base::ListValue> args(new base::ListValue);
+  auto args = base::MakeUnique<base::ListValue>();
   int tab_id = ExtensionTabUtil::GetTabId(new_contents);
   args->AppendInteger(tab_id);
 
-  base::DictionaryValue* object_args = new base::DictionaryValue();
+  auto object_args = base::MakeUnique<base::DictionaryValue>();
   object_args->Set(tabs_constants::kWindowIdKey,
                    new FundamentalValue(
                        ExtensionTabUtil::GetWindowIdOfTab(new_contents)));
-  args->Append(object_args);
+  args->Append(object_args->CreateDeepCopy());
 
   // The onActivated event replaced onActiveChanged and onSelectionChanged. The
   // deprecated events take two arguments: tabId, {windowId}.
   Profile* profile =
       Profile::FromBrowserContext(new_contents->GetBrowserContext());
   EventRouter::UserGestureState gesture =
       reason & CHANGE_REASON_USER_GESTURE
       ? EventRouter::USER_GESTURE_ENABLED
       : EventRouter::USER_GESTURE_NOT_ENABLED;
   DispatchEvent(profile, events::TABS_ON_SELECTION_CHANGED,
-                tabs::OnSelectionChanged::kEventName,
-                std::unique_ptr<base::ListValue>(args->DeepCopy()), gesture);
+                tabs::OnSelectionChanged::kEventName, args->CreateDeepCopy(),
+                gesture);
   DispatchEvent(profile, events::TABS_ON_ACTIVE_CHANGED,
-                tabs::OnActiveChanged::kEventName,
-                std::unique_ptr<base::ListValue>(args->DeepCopy()), gesture);
+                tabs::OnActiveChanged::kEventName, std::move(args), gesture);
 
   // The onActivated event takes one argument: {windowId, tabId}.
-  args->Remove(0, NULL);
+  auto on_activated_args = base::MakeUnique<base::ListValue>();
   object_args->Set(tabs_constants::kTabIdKey,
                    new FundamentalValue(tab_id));
+  on_activated_args->Append(std::move(object_args));
   DispatchEvent(profile, events::TABS_ON_ACTIVATED,
-                tabs::OnActivated::kEventName, std::move(args), gesture);
+                tabs::OnActivated::kEventName, std::move(on_activated_args),
+                gesture);
 }
 
 void TabsEventRouter::TabSelectionChanged(
     TabStripModel* tab_strip_model,
     const ui::ListSelectionModel& old_model) {
   ui::ListSelectionModel::SelectedIndices new_selection =
       tab_strip_model->selection_model().selected_indices();
   std::unique_ptr<base::ListValue> all_tabs(new base::ListValue);
 
   for (size_t i = 0; i < new_selection.size(); ++i) {
@@ skipping 231 matching lines @@
   int tab_index = -1;
 
   if (ExtensionTabUtil::GetTabStripModel(contents, &tab_strip, &tab_index)) {
     std::set<std::string> changed_property_names;
     changed_property_names.insert(tabs_constants::kAutoDiscardableKey);
     DispatchTabUpdatedEvent(contents, std::move(changed_property_names));
   }
 }
 
 }  // namespace extensions