Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Unified Diff: extensions/common/permissions/manifest_permission.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/common/extension_l10n_util_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/manifest_permission.cc
diff --git a/extensions/common/permissions/manifest_permission.cc b/extensions/common/permissions/manifest_permission.cc
index 9315d1d0418d8d0ff78d11565f40a9d33b5c894d..beb8fe3e5f03715754ce8d226c02977faa4f5188 100644
--- a/extensions/common/permissions/manifest_permission.cc
+++ b/extensions/common/permissions/manifest_permission.cc
@@ -29,15 +29,13 @@ bool ManifestPermission::Equal(const ManifestPermission* rhs) const {
void ManifestPermission::GetSize(base::PickleSizer* s) const {
base::ListValue singleton;
- base::Value* value = ToValue().release();
- singleton.Append(value);
+ singleton.Append(ToValue());
IPC::GetParamSize(s, singleton);
}
void ManifestPermission::Write(base::Pickle* m) const {
base::ListValue singleton;
- base::Value* value = ToValue().release();
- singleton.Append(value);
+ singleton.Append(ToValue());
IPC::WriteParam(m, singleton);
}
« no previous file with comments | « extensions/common/extension_l10n_util_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698