Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3149)

Unified Diff: extensions/browser/app_window/app_window_contents.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/app_window/app_window_contents.cc
diff --git a/extensions/browser/app_window/app_window_contents.cc b/extensions/browser/app_window/app_window_contents.cc
index 3cb0cb850de3f289aa460fa311a7ea026df77995..0d5f033c7efafc175859d61d1a7b754840c4caf1 100644
--- a/extensions/browser/app_window/app_window_contents.cc
+++ b/extensions/browser/app_window/app_window_contents.cc
@@ -4,6 +4,7 @@
#include "extensions/browser/app_window/app_window_contents.h"
+#include <memory>
#include <string>
#include <utility>
@@ -65,9 +66,10 @@ void AppWindowContentsImpl::LoadContents(int32_t creator_process_id) {
void AppWindowContentsImpl::NativeWindowChanged(
NativeAppWindow* native_app_window) {
base::ListValue args;
- base::DictionaryValue* dictionary = new base::DictionaryValue();
- args.Append(dictionary);
- host_->GetSerializedState(dictionary);
+ std::unique_ptr<base::DictionaryValue> dictionary(
+ new base::DictionaryValue());
+ host_->GetSerializedState(dictionary.get());
+ args.Append(std::move(dictionary));
content::RenderFrameHost* rfh = web_contents_->GetMainFrame();
rfh->Send(new ExtensionMsg_MessageInvoke(
« no previous file with comments | « extensions/browser/api/web_request/web_request_api_helpers.cc ('k') | extensions/browser/computed_hashes.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698