Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

chrome/browser/extensions/api/debugger/debugger_api.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Implements the Chrome Extensions Debugger API.
 
 #include "chrome/browser/extensions/api/debugger/debugger_api.h"
 
 #include <stddef.h>
 
@@ skipping 659 matching lines @@
 const char kTargetIdField[] = "id";
 const char kTargetTypeField[] = "type";
 const char kTargetTitleField[] = "title";
 const char kTargetAttachedField[] = "attached";
 const char kTargetUrlField[] = "url";
 const char kTargetFaviconUrlField[] = "faviconUrl";
 const char kTargetTabIdField[] = "tabId";
 const char kTargetExtensionIdField[] = "extensionId";
 const char kTargetTypeWorker[] = "worker";
 
-base::Value* SerializeTarget(scoped_refptr<DevToolsAgentHost> host) {
-  base::DictionaryValue* dictionary = new base::DictionaryValue();
+std::unique_ptr<base::Value> SerializeTarget(
+    scoped_refptr<DevToolsAgentHost> host) {
+  std::unique_ptr<base::DictionaryValue> dictionary(
+      new base::DictionaryValue());
   dictionary->SetString(kTargetIdField, host->GetId());
   dictionary->SetString(kTargetTitleField, host->GetTitle());
   dictionary->SetBoolean(kTargetAttachedField, host->IsAttached());
   dictionary->SetString(kTargetUrlField, host->GetURL().spec());
 
   std::string type = host->GetType();
   if (type == DevToolsAgentHost::kTypePage) {
     int tab_id =
         extensions::ExtensionTabUtil::GetTabId(host->GetWebContents());
     dictionary->SetInteger(kTargetTabIdField, tab_id);
   } else if (type == ChromeDevToolsManagerDelegate::kTypeBackgroundPage) {
     dictionary->SetString(kTargetExtensionIdField, host->GetURL().host());
   }
 
   if (type == DevToolsAgentHost::kTypeServiceWorker ||
       type == DevToolsAgentHost::kTypeSharedWorker) {
     type = kTargetTypeWorker;
   }
 
   dictionary->SetString(kTargetTypeField, type);
 
   GURL favicon_url = host->GetFaviconURL();
   if (favicon_url.is_valid())
     dictionary->SetString(kTargetFaviconUrlField, favicon_url.spec());
 
-  return dictionary;
+  return std::move(dictionary);

[Devlin, 2016/09/12 19:12:34]

isn't this a pessimising move?

[dcheng, 2016/09/12 20:26:45]

std::move() is required when the return type is different. In this case, it's
easy enough to just make them match, so I've done so.

[Devlin, 2016/09/14 14:56:52]

Ah, interesting.  I was wondering why there wasn't a compiler warning.

 }
 
 }  // namespace
 
 DebuggerGetTargetsFunction::DebuggerGetTargetsFunction() {
 }
 
 DebuggerGetTargetsFunction::~DebuggerGetTargetsFunction() {
 }
 
 bool DebuggerGetTargetsFunction::RunAsync() {
   content::DevToolsAgentHost::List list = DevToolsAgentHost::GetOrCreateAll();
   content::BrowserThread::PostTask(
       content::BrowserThread::UI,
       FROM_HERE,
       base::Bind(&DebuggerGetTargetsFunction::SendTargetList, this, list));
   return true;
 }
 
 void DebuggerGetTargetsFunction::SendTargetList(
     const content::DevToolsAgentHost::List& target_list) {
   std::unique_ptr<base::ListValue> result(new base::ListValue());
   for (size_t i = 0; i < target_list.size(); ++i)
     result->Append(SerializeTarget(target_list[i]));
   SetResult(std::move(result));
   SendResponse(true);
 }
 
 }  // namespace extensions