Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Side by Side Diff: chrome/browser/extensions/api/tabs/app_window_controller.h

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_
6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_ 6 #define CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/containers/scoped_ptr_hash_map.h" 10 #include "base/containers/scoped_ptr_hash_map.h"
(...skipping 13 matching lines...) Expand all
24 AppWindowController(AppWindow* window, 24 AppWindowController(AppWindow* window,
25 std::unique_ptr<AppBaseWindow> base_window, 25 std::unique_ptr<AppBaseWindow> base_window,
26 Profile* profile); 26 Profile* profile);
27 ~AppWindowController() override; 27 ~AppWindowController() override;
28 28
29 // extensions::WindowController: 29 // extensions::WindowController:
30 int GetWindowId() const override; 30 int GetWindowId() const override;
31 std::string GetWindowTypeText() const override; 31 std::string GetWindowTypeText() const override;
32 std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs( 32 std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(
33 const Extension* extension) const override; 33 const Extension* extension) const override;
34 base::DictionaryValue* CreateTabValue(const Extension* extension,
35 int tab_index) const override;
36 std::unique_ptr<api::tabs::Tab> CreateTabObject( 34 std::unique_ptr<api::tabs::Tab> CreateTabObject(
37 const extensions::Extension* extension, 35 const extensions::Extension* extension,
38 int tab_index) const override; 36 int tab_index) const override;
39 37
40 bool CanClose(Reason* reason) const override; 38 bool CanClose(Reason* reason) const override;
41 void SetFullscreenMode(bool is_fullscreen, 39 void SetFullscreenMode(bool is_fullscreen,
42 const GURL& extension_url) const override; 40 const GURL& extension_url) const override;
43 Browser* GetBrowser() const override; 41 Browser* GetBrowser() const override;
44 bool IsVisibleToExtension(const Extension* extension) const override; 42 bool IsVisibleToExtension(const Extension* extension) const override;
45 43
46 private: 44 private:
47 AppWindow* app_window_; // Owns us. 45 AppWindow* app_window_; // Owns us.
48 std::unique_ptr<AppBaseWindow> base_window_; 46 std::unique_ptr<AppBaseWindow> base_window_;
49 47
50 DISALLOW_COPY_AND_ASSIGN(AppWindowController); 48 DISALLOW_COPY_AND_ASSIGN(AppWindowController);
51 }; 49 };
52 50
53 } // namespace extensions 51 } // namespace extensions
54 52
55 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_ 53 #endif // CHROME_BROWSER_EXTENSIONS_API_TABS_APP_WINDOW_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698