Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/files/file_util.h"
@@ skipping 97 matching lines @@
 
   std::vector<std::unique_ptr<TestExtensionDir>> test_extension_dirs_;
 
   DISALLOW_COPY_AND_ASSIGN(DeveloperPrivateApiUnitTest);
 };
 
 bool DeveloperPrivateApiUnitTest::RunFunction(
     const scoped_refptr<UIThreadExtensionFunction>& function,
     const base::ListValue& args) {
   return extension_function_test_utils::RunFunction(
-      function.get(), base::WrapUnique(args.DeepCopy()), browser(),
+      function.get(), args.CreateDeepCopy(), browser(),
       extension_function_test_utils::NONE);
 }
 
 const Extension* DeveloperPrivateApiUnitTest::LoadUnpackedExtension() {
   const char kManifest[] =
       "{"
       " \"name\": \"foo\","
       " \"version\": \"1.0\","
       " \"manifest_version\": 2,"
       " \"permissions\": [\"*://*/*\"]"
@@ skipping 42 matching lines @@
   return extension.get();
 }
 
 void DeveloperPrivateApiUnitTest::TestExtensionPrefSetting(
     const base::Callback<bool()>& has_pref,
     const std::string& key,
     const std::string& extension_id) {
   scoped_refptr<UIThreadExtensionFunction> function(
       new api::DeveloperPrivateUpdateExtensionConfigurationFunction());
 
-  base::ListValue args;
-  base::DictionaryValue* parameters = new base::DictionaryValue();
-  parameters->SetString("extensionId", extension_id);
-  parameters->SetBoolean(key, true);
-  args.Append(parameters);
-
   EXPECT_FALSE(has_pref.Run()) << key;
 
-  EXPECT_FALSE(RunFunction(function, args)) << key;
-  EXPECT_EQ(std::string("This action requires a user gesture."),
-            function->GetError());
+  {
+    auto parameters = base::MakeUnique<base::DictionaryValue>();
+    parameters->SetString("extensionId", extension_id);
+    parameters->SetBoolean(key, true);
 
-  ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
-  function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
-  EXPECT_TRUE(RunFunction(function, args)) << key;
-  EXPECT_TRUE(has_pref.Run()) << key;
+    base::ListValue args;
+    args.Append(std::move(parameters));
+    EXPECT_FALSE(RunFunction(function, args)) << key;
+    EXPECT_EQ("This action requires a user gesture.", function->GetError());
 
-  parameters->SetBoolean(key, false);
-  function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
-  EXPECT_TRUE(RunFunction(function, args)) << key;
-  EXPECT_FALSE(has_pref.Run()) << key;
+    ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
+    function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
+    EXPECT_TRUE(RunFunction(function, args)) << key;
+    EXPECT_TRUE(has_pref.Run()) << key;
+  }
+
+  {
+    auto parameters = base::MakeUnique<base::DictionaryValue>();
+    parameters->SetString("extensionId", extension_id);
+    parameters->SetBoolean(key, false);
+
+    base::ListValue args;
+    args.Append(std::move(parameters));
+
+    ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
+    function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
+    EXPECT_TRUE(RunFunction(function, args)) << key;
+    EXPECT_FALSE(has_pref.Run()) << key;
+  }
 }
 
 testing::AssertionResult DeveloperPrivateApiUnitTest::TestPackExtensionFunction(
     const base::ListValue& args,
     api::developer_private::PackStatus expected_status,
     int expected_flags) {
   scoped_refptr<UIThreadExtensionFunction> function(
       new api::DeveloperPrivatePackDirectoryFunction());
   if (!RunFunction(function, args))
     return testing::AssertionFailure() << "Could not run function.";
@@ skipping 348 matching lines @@
           .Append(
               DictionaryBuilder().Set("extensionId", extension->id()).Build())
           .Build();
   function = new api::DeveloperPrivateDeleteExtensionErrorsFunction();
   EXPECT_TRUE(RunFunction(function, *args)) << function->GetError();
   // No more errors!
   EXPECT_TRUE(error_console->GetErrorsForExtension(extension->id()).empty());
 }
 
 }  // namespace extensions