Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

chrome/browser/extensions/api/commands/commands.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/commands/commands.h"
 
 #include <memory>
 #include <utility>
 
 #include "chrome/browser/extensions/api/commands/command_service.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace {
 
-base::DictionaryValue* CreateCommandValue(
-    const extensions::Command& command, bool active) {
-  base::DictionaryValue* result = new base::DictionaryValue();
+std::unique_ptr<base::DictionaryValue> CreateCommandValue(
+    const extensions::Command& command,
+    bool active) {
+  std::unique_ptr<base::DictionaryValue> result(new base::DictionaryValue());

[Devlin, 2016/09/12 19:12:34]

I'm assuming that future MakeUnique calls are orthogonal to this CL?

[dcheng, 2016/09/12 20:26:45]

This CL has been in progress for awhile: previously, we didn't have the clang
plugin check for using auto* for pointer types (though it's still not enabled by
default, we're getting closer... I hope) and writing std::unique_ptr<T> x =
base::MakeUnique<T>(...) is strictly longer. Now that we're close, I feel
relatively comfortable using the auto x = base::MakeUnique<T> pattern. If you
feel strongly, I can try to be uniform about it in this CL.

   result->SetString("name", command.command_name());
   result->SetString("description", command.description());
   result->SetString("shortcut",
                     active ? command.accelerator().GetShortcutText() :
                              base::string16());
   return result;
 }
 
 }  // namespace
 
@@ skipping 31 matching lines @@
     extensions::Command command = command_service->FindCommandByName(
         extension_->id(), iter->second.command_name());
     ui::Accelerator shortcut_assigned = command.accelerator();
     active = (shortcut_assigned.key_code() != ui::VKEY_UNKNOWN);
 
     command_list->Append(CreateCommandValue(iter->second, active));
   }
 
   return RespondNow(OneArgument(std::move(command_list)));
 }