Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/browser/extensions/browser_extension_window_controller.cc

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)
Patch Set: ... I hate C++ Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/browser_extension_window_controller.cc
diff --git a/chrome/browser/extensions/browser_extension_window_controller.cc b/chrome/browser/extensions/browser_extension_window_controller.cc
index 1ffee7e02e0064b62ec03bc9ec3ac62773a0588f..64e0898385028ec692505270021c9f9db22a09fd 100644
--- a/chrome/browser/extensions/browser_extension_window_controller.cc
+++ b/chrome/browser/extensions/browser_extension_window_controller.cc
@@ -52,17 +52,6 @@ BrowserExtensionWindowController::CreateWindowValueWithTabs(
return result;
}
-base::DictionaryValue* BrowserExtensionWindowController::CreateTabValue(
- const extensions::Extension* extension, int tab_index) const {
- TabStripModel* tab_strip = browser_->tab_strip_model();
- base::DictionaryValue* result =
- extensions::ExtensionTabUtil::CreateTabObject(
- tab_strip->GetWebContentsAt(tab_index), tab_strip, tab_index)
- ->ToValue()
- .release();
- return result;
-}
-
std::unique_ptr<extensions::api::tabs::Tab>
BrowserExtensionWindowController::CreateTabObject(
const extensions::Extension* extension,
« no previous file with comments | « chrome/browser/extensions/browser_extension_window_controller.h ('k') | chrome/browser/extensions/menu_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698