chrome/browser/extensions/api/tabs/app_window_controller.h - Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/tabs/app_window_controller.h

Issue 2323993004: Remove use of deprecated base::ListValue::Append(Value*) overload in extensions. (Closed)

Patch Set: ... I hate C++ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/tabs/app_window_controller.h

diff --git a/chrome/browser/extensions/api/tabs/app_window_controller.h b/chrome/browser/extensions/api/tabs/app_window_controller.h

index d7a868cd6027f25c5d79961b9ea074eccb0b7259..7f829741012406607aea0d9ae01a6c07dc0dc39d 100644

--- a/chrome/browser/extensions/api/tabs/app_window_controller.h

+++ b/chrome/browser/extensions/api/tabs/app_window_controller.h

@@ -31,8 +31,6 @@ class AppWindowController : public WindowController {

std::string GetWindowTypeText() const override;

std::unique_ptr<base::DictionaryValue> CreateWindowValueWithTabs(

const Extension* extension) const override;

- base::DictionaryValue* CreateTabValue(const Extension* extension,

- int tab_index) const override;

std::unique_ptr<api::tabs::Tab> CreateTabObject(

const extensions::Extension* extension,

int tab_index) const override;