Remove use of deprecated base::ListValue::Append(Value*) overload in extensions.

chrome/browser/extensions/api/developer_private/developer_private_api_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/developer_private/developer_private_api.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/files/file_util.h"
@@ skipping 161 matching lines @@
 }
 
 void DeveloperPrivateApiUnitTest::TestExtensionPrefSetting(
     const base::Callback<bool()>& has_pref,
     const std::string& key,
     const std::string& extension_id) {
   scoped_refptr<UIThreadExtensionFunction> function(
       new api::DeveloperPrivateUpdateExtensionConfigurationFunction());
 
   base::ListValue args;
-  base::DictionaryValue* parameters = new base::DictionaryValue();
+  std::unique_ptr<base::DictionaryValue> parameters(
+      new base::DictionaryValue());
   parameters->SetString("extensionId", extension_id);
   parameters->SetBoolean(key, true);
-  args.Append(parameters);
+  args.Append(std::move(parameters));
 
   EXPECT_FALSE(has_pref.Run()) << key;
 
   EXPECT_FALSE(RunFunction(function, args)) << key;
   EXPECT_EQ(std::string("This action requires a user gesture."),
             function->GetError());
 
   ExtensionFunction::ScopedUserGestureForTests scoped_user_gesture;
   function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
   EXPECT_TRUE(RunFunction(function, args)) << key;
   EXPECT_TRUE(has_pref.Run()) << key;
 
   parameters->SetBoolean(key, false);

[Devlin, 2016/09/12 19:12:34]

badness :(

[Devlin, 2016/09/12 21:01:30]

This one wasn't addressed?

[dcheng, 2016/09/13 20:54:20]

Yeah, I missed this failure in the test runs. Fixed.

   function = new api::DeveloperPrivateUpdateExtensionConfigurationFunction();
   EXPECT_TRUE(RunFunction(function, args)) << key;
   EXPECT_FALSE(has_pref.Run()) << key;
 }
 
 testing::AssertionResult DeveloperPrivateApiUnitTest::TestPackExtensionFunction(
     const base::ListValue& args,
     api::developer_private::PackStatus expected_status,
     int expected_flags) {
   scoped_refptr<UIThreadExtensionFunction> function(
@@ skipping 351 matching lines @@
           .Append(
               DictionaryBuilder().Set("extensionId", extension->id()).Build())
           .Build();
   function = new api::DeveloperPrivateDeleteExtensionErrorsFunction();
   EXPECT_TRUE(RunFunction(function, *args)) << function->GetError();
   // No more errors!
   EXPECT_TRUE(error_console->GetErrorsForExtension(extension->id()).empty());
 }
 
 }  // namespace extensions