Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed)

Created:
4 years, 4 months ago by dgozman
Modified:
4 years, 4 months ago
Reviewers:
kozy, lushnikov, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Fill ExceptionDetails with more details, unify usage across protocol. BUG=635947 Committed: https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0 Cr-Commit-Position: refs/heads/master@{#412729}

Patch Set 1 #

Patch Set 2 : browser test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+301 lines, -160 lines) Patch
M chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise.html View 5 chunks +20 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise-expected.txt View 3 chunks +17 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt View 3 chunks +27 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt View 2 chunks +18 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async.html View 3 chunks +13 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt View 2 chunks +16 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html View 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt View 4 chunks +27 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html View 1 chunk +5 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +43 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RemoteObject.js View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +7 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 2 chunks +4 lines, -19 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/JavaScriptCompiler.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScript.cpp View 3 chunks +27 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8ConsoleMessage.cpp View 1 chunk +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/V8RuntimeAgentImpl.cpp View 5 chunks +15 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/js_protocol.json View 1 4 chunks +9 lines, -9 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
dgozman
Could you please take a look?
4 years, 4 months ago (2016-08-17 19:01:11 UTC) #2
dgozman
Andrey, could you please take a look at frontend?
4 years, 4 months ago (2016-08-17 19:10:17 UTC) #6
pfeldman
lgtm
4 years, 4 months ago (2016-08-17 21:28:08 UTC) #9
lushnikov
lgtm
4 years, 4 months ago (2016-08-18 01:23:09 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2249743006/20001
4 years, 4 months ago (2016-08-18 01:26:37 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-18 03:56:38 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-18 03:58:28 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/30bce6e3d351554a14c1d64568979b25802ee6e0
Cr-Commit-Position: refs/heads/master@{#412729}

Powered by Google App Engine
This is Rietveld 408576698