Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/Script.js

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/Script.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
index ea0942516f4e7d43a707cf5ae1e223271b2e7c0d..135cfe1d3d6345d20dedddeb7e1594c3a2c1062e 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/Script.js
@@ -244,14 +244,14 @@ WebInspector.Script.prototype = {
* @param {!Array.<!DebuggerAgent.CallFrame>=} callFrames
* @param {boolean=} stackChanged
* @param {!RuntimeAgent.StackTrace=} asyncStackTrace
- * @param {!RuntimeAgent.ExceptionDetails=} compileError
+ * @param {!RuntimeAgent.ExceptionDetails=} exceptionDetails
*/
- function didEditScriptSource(error, callFrames, stackChanged, asyncStackTrace, compileError)
+ function didEditScriptSource(error, callFrames, stackChanged, asyncStackTrace, exceptionDetails)
{
- if (!error && !compileError)
+ if (!error && !exceptionDetails)
this._source = newSource;
var needsStepIn = !!stackChanged;
- callback(error, compileError, callFrames, asyncStackTrace, needsStepIn);
+ callback(error, exceptionDetails, callFrames, asyncStackTrace, needsStepIn);
}
newSource = WebInspector.Script._trimSourceURLComment(newSource);

Powered by Google App Engine
This is Rietveld 408576698