Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScript.h

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 bool wrapPropertyInArray(ErrorString*, v8::Local<v8::Array>, v8::Local<v8::S tring> property, const String16& groupName, bool forceValueType = false, bool ge neratePreview = false) const; 66 bool wrapPropertyInArray(ErrorString*, v8::Local<v8::Array>, v8::Local<v8::S tring> property, const String16& groupName, bool forceValueType = false, bool ge neratePreview = false) const;
67 bool wrapObjectsInArray(ErrorString*, v8::Local<v8::Array>, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const; 67 bool wrapObjectsInArray(ErrorString*, v8::Local<v8::Array>, const String16& groupName, bool forceValueType = false, bool generatePreview = false) const;
68 std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Val ue> table, v8::Local<v8::Value> columns) const; 68 std::unique_ptr<protocol::Runtime::RemoteObject> wrapTable(v8::Local<v8::Val ue> table, v8::Local<v8::Value> columns) const;
69 69
70 bool findObject(ErrorString*, const RemoteObjectId&, v8::Local<v8::Value>*) const; 70 bool findObject(ErrorString*, const RemoteObjectId&, v8::Local<v8::Value>*) const;
71 String16 objectGroupName(const RemoteObjectId&) const; 71 String16 objectGroupName(const RemoteObjectId&) const;
72 void releaseObjectGroup(const String16&); 72 void releaseObjectGroup(const String16&);
73 void setCustomObjectFormatterEnabled(bool); 73 void setCustomObjectFormatterEnabled(bool);
74 v8::MaybeLocal<v8::Value> resolveCallArgument(ErrorString*, protocol::Runtim e::CallArgument*); 74 v8::MaybeLocal<v8::Value> resolveCallArgument(ErrorString*, protocol::Runtim e::CallArgument*);
75 75
76 std::unique_ptr<protocol::Runtime::ExceptionDetails> createExceptionDetails( v8::Local<v8::Message>); 76 std::unique_ptr<protocol::Runtime::ExceptionDetails> createExceptionDetails( ErrorString*, const v8::TryCatch&, const String16& groupName, bool generatePrevi ew);
77 void wrapEvaluateResult(ErrorString*, 77 void wrapEvaluateResult(ErrorString*,
78 v8::MaybeLocal<v8::Value> maybeResultValue, 78 v8::MaybeLocal<v8::Value> maybeResultValue,
79 const v8::TryCatch&, 79 const v8::TryCatch&,
80 const String16& objectGroup, 80 const String16& objectGroup,
81 bool returnByValue, 81 bool returnByValue,
82 bool generatePreview, 82 bool generatePreview,
83 std::unique_ptr<protocol::Runtime::RemoteObject>* result, 83 std::unique_ptr<protocol::Runtime::RemoteObject>* result,
84 Maybe<protocol::Runtime::ExceptionDetails>*); 84 Maybe<protocol::Runtime::ExceptionDetails>*);
85 v8::Local<v8::Value> lastEvaluationResult() const; 85 v8::Local<v8::Value> lastEvaluationResult() const;
86 86
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
162 InspectedContext* m_context; 162 InspectedContext* m_context;
163 v8::Global<v8::Value> m_value; 163 v8::Global<v8::Value> m_value;
164 v8::Global<v8::Value> m_lastEvaluationResult; 164 v8::Global<v8::Value> m_lastEvaluationResult;
165 std::unique_ptr<InjectedScriptNative> m_native; 165 std::unique_ptr<InjectedScriptNative> m_native;
166 v8::Global<v8::Object> m_commandLineAPI; 166 v8::Global<v8::Object> m_commandLineAPI;
167 }; 167 };
168 168
169 } // namespace v8_inspector 169 } // namespace v8_inspector
170 170
171 #endif 171 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698