third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-await-promise.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html

index 1954945906df260cff5948871bdbc9ec0429fcf9..8ebeac2307126e30ac033b3a05ef5734918abb97 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/debugger/setScriptSource.html

@@ -140,11 +140,11 @@ function test()

}

function errorCallbackSetScriptSource2(result) {

- var compileError = result.compileError;

- logCheck("Has error reported", !!compileError);

- logCheck("Reported error is a compile error", !!compileError);

- if (compileError)

- logEqualsCheck(compileError.lineNumber, 1);

+ var exceptionDetails = result.exceptionDetails;

+ logCheck("Has error reported", !!exceptionDetails);

+ logCheck("Reported error is a compile error", !!exceptionDetails);

+ if (exceptionDetails)

+ logEqualsCheck(exceptionDetails.lineNumber, 1);

return next;

}