Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
index 3dfd8dafb03a3d25e4b30f97b1d1ea4264cea23a..ff936cf25e7b6883a194ab10c34cdd24788f178b 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js
@@ -384,45 +384,28 @@ WebInspector.RuntimeDispatcher.prototype = {
/**
* @override
- * @param {number} exceptionId
* @param {number} timestamp
- * @param {!RuntimeAgent.ExceptionDetails} details
- * @param {!RuntimeAgent.RemoteObject=} exception
- * @param {number=} executionContextId
+ * @param {!RuntimeAgent.ExceptionDetails} exceptionDetails
*/
- exceptionThrown: function(exceptionId, timestamp, details, exception, executionContextId)
+ exceptionThrown: function(timestamp, exceptionDetails)
{
- var consoleMessage = new WebInspector.ConsoleMessage(
- this._runtimeModel.target(),
- WebInspector.ConsoleMessage.MessageSource.JS,
- WebInspector.ConsoleMessage.MessageLevel.Error,
- details.text,
- undefined,
- details.url,
- details.lineNumber,
- details.columnNumber,
- undefined,
- exception ? [WebInspector.RemoteObject.fromLocalObject(details.text), exception] : undefined,
- details.stackTrace,
- timestamp,
- executionContextId,
- details.scriptId);
- consoleMessage.setExceptionId(exceptionId);
+ var consoleMessage = WebInspector.ConsoleMessage.fromException(this._runtimeModel.target(), exceptionDetails, undefined, timestamp, undefined);
+ consoleMessage.setExceptionId(exceptionDetails.exceptionId);
this._runtimeModel.target().consoleModel.addMessage(consoleMessage);
},
/**
* @override
- * @param {string} message
+ * @param {string} reason
* @param {number} exceptionId
*/
- exceptionRevoked: function(message, exceptionId)
+ exceptionRevoked: function(reason, exceptionId)
{
var consoleMessage = new WebInspector.ConsoleMessage(
this._runtimeModel.target(),
WebInspector.ConsoleMessage.MessageSource.JS,
WebInspector.ConsoleMessage.MessageLevel.RevokedError,
- message,
+ reason,
undefined,
undefined,
undefined,

Powered by Google App Engine
This is Rietveld 408576698