third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-evaluate-async-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

4 <script>	4 <script>

5	5

6 function test()	6 function test()

7 {	7 {

8 InspectorTest.runTestSuite([	8 InspectorTest.runTestSuite([

9 function testRunAndCompileWithoutAgentEnable(next)	9 function testRunAndCompileWithoutAgentEnable(next)

10 {	10 {

(...skipping 100 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
111 ]);	111 ]);

112	112

113 function dumpResult(result)	113 function dumpResult(result)

114 {	114 {

115 if (result.error) {	115 if (result.error) {

116 result.error.code = 0;	116 result.error.code = 0;

117 InspectorTest.logObject(result.error);	117 InspectorTest.logObject(result.error);

118 return;	118 return;

119 }	119 }

120 result = result.result;	120 result = result.result;

	121 if (result.exceptionDetails) {

	122 result.exceptionDetails.exceptionId = 0;

	123 result.exceptionDetails.exception.objectId = 0;

	124 }

121 if (result.exceptionDetails && result.exceptionDetails.scriptId)	125 if (result.exceptionDetails && result.exceptionDetails.scriptId)

122 result.exceptionDetails.scriptId = 0;	126 result.exceptionDetails.scriptId = 0;

123 if (result.exceptionDetails && result.exceptionDetails.stackTrace) {	127 if (result.exceptionDetails && result.exceptionDetails.stackTrace) {

124 for (var frame of result.exceptionDetails.stackTrace.callFrames)	128 for (var frame of result.exceptionDetails.stackTrace.callFrames)

125 frame.scriptId = 0;	129 frame.scriptId = 0;

126 }	130 }

127 if (result.result && result.result.objectId)	131 if (result.result && result.result.objectId)

128 result.result.objectId = "[ObjectId]";	132 result.result.objectId = "[ObjectId]";

129 InspectorTest.logObject(result);	133 InspectorTest.logObject(result);

130 }	134 }

131 }	135 }

132 </script>	136 </script>

133 </head>	137 </head>

134 <body onLoad="runTest();">	138 <body onLoad="runTest();">

135 Tests that Runtime.compileScript and Runtime.runScript work with awaitPromise fl ag.	139 Tests that Runtime.compileScript and Runtime.runScript work with awaitPromise fl ag.

136 </body>	140 </body>

137 </html>	141 </html>

138	142

OLD	NEW