third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-callFunctionOn-async-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-compileScript-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>	3 <script type="text/javascript" src="../../http/tests/inspector-protocol/inspecto r-protocol-test.js"></script>

4 <script>	4 <script>

5 function test()	5 function test()

6 {	6 {

7 var executionContextId;	7 var executionContextId;

8	8

9 InspectorTest.sendCommand("Debugger.enable", {}, onDebuggerEnabled);	9 InspectorTest.sendCommand("Debugger.enable", {}, onDebuggerEnabled);

10	10

(...skipping 31 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
42 expression: expression,	42 expression: expression,

43 sourceURL: sourceURL,	43 sourceURL: sourceURL,

44 persistScript: persistScript,	44 persistScript: persistScript,

45 executionContextId: executionContextId	45 executionContextId: executionContextId

46 }, onCompiled);	46 }, onCompiled);

47 return promise;	47 return promise;

48	48

49 function onCompiled(messageObject)	49 function onCompiled(messageObject)

50 {	50 {

51 var result = messageObject.result;	51 var result = messageObject.result;

52 if (result.exceptionDetails)	52 if (result.exceptionDetails) {

	53 result.exceptionDetails.exceptionId = 0;

	54 result.exceptionDetails.exception.objectId = 0;

53 result.exceptionDetails.scriptId = 0;	55 result.exceptionDetails.scriptId = 0;

	56 }

54 if (result.scriptId)	57 if (result.scriptId)

55 result.scriptId = 0;	58 result.scriptId = 0;

56 InspectorTest.logObject(result, "compilation result: ");	59 InspectorTest.logObject(result, "compilation result: ");

57 InspectorTest.log("-----");	60 InspectorTest.log("-----");

58 callback();	61 callback();

59 }	62 }

60 }	63 }

61 }	64 }

62 </script>	65 </script>

63 </head>	66 </head>

64 <body onLoad="runTest();"></body>	67 <body onLoad="runTest();"></body>

65 </html>	68 </html>

OLD	NEW