third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.h

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp ('k') | third_party/WebKit/Source/platform/v8_inspector/V8InspectorImpl.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (c) 2010, Google Inc. All rights reserved.	2 * Copyright (c) 2010, Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 67 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
78 unsigned exceptionThrown(v8::Local<v8::Context>, const String16& message, v8 ::Local<v8::Value> exception, const String16& detailedMessage, const String16& u rl, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, i nt scriptId) override;	78 unsigned exceptionThrown(v8::Local<v8::Context>, const String16& message, v8 ::Local<v8::Value> exception, const String16& detailedMessage, const String16& u rl, unsigned lineNumber, unsigned columnNumber, std::unique_ptr<V8StackTrace>, i nt scriptId) override;

79 void exceptionRevoked(v8::Local<v8::Context>, unsigned exceptionId, const St ring16& message) override;	79 void exceptionRevoked(v8::Local<v8::Context>, unsigned exceptionId, const St ring16& message) override;

80 std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>) ov erride;	80 std::unique_ptr<V8StackTrace> createStackTrace(v8::Local<v8::StackTrace>) ov erride;

81 std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) override;	81 std::unique_ptr<V8StackTrace> captureStackTrace(bool fullStack) override;

82 void asyncTaskScheduled(const String16& taskName, void* task, bool recurring ) override;	82 void asyncTaskScheduled(const String16& taskName, void* task, bool recurring ) override;

83 void asyncTaskCanceled(void* task) override;	83 void asyncTaskCanceled(void* task) override;

84 void asyncTaskStarted(void* task) override;	84 void asyncTaskStarted(void* task) override;

85 void asyncTaskFinished(void* task) override;	85 void asyncTaskFinished(void* task) override;

86 void allAsyncTasksCanceled() override;	86 void allAsyncTasksCanceled() override;

87	87

	88 unsigned nextExceptionId() { return ++m_lastExceptionId; }

88 void enableStackCapturingIfNeeded();	89 void enableStackCapturingIfNeeded();

89 void disableStackCapturingIfNeeded();	90 void disableStackCapturingIfNeeded();

90 void muteExceptions(int contextGroupId);	91 void muteExceptions(int contextGroupId);

91 void unmuteExceptions(int contextGroupId);	92 void unmuteExceptions(int contextGroupId);

92 V8ConsoleMessageStorage* ensureConsoleMessageStorage(int contextGroupId);	93 V8ConsoleMessageStorage* ensureConsoleMessageStorage(int contextGroupId);

93 using ContextByIdMap = protocol::HashMap<int, std::unique_ptr<InspectedConte xt>>;	94 using ContextByIdMap = protocol::HashMap<int, std::unique_ptr<InspectedConte xt>>;

94 void discardInspectedContext(int contextGroupId, int contextId);	95 void discardInspectedContext(int contextGroupId, int contextId);

95 const ContextByIdMap* contextGroup(int contextGroupId);	96 const ContextByIdMap* contextGroup(int contextGroupId);

96 void disconnect(V8InspectorSessionImpl*);	97 void disconnect(V8InspectorSessionImpl*);

97 V8InspectorSessionImpl* sessionForContextGroup(int contextGroupId);	98 V8InspectorSessionImpl* sessionForContextGroup(int contextGroupId);

(...skipping 19 matching lines...) Expand all Loading...
117 SessionMap m_sessions;	118 SessionMap m_sessions;

118	119

119 using ConsoleStorageMap = protocol::HashMap<int, std::unique_ptr<V8ConsoleMe ssageStorage>>;	120 using ConsoleStorageMap = protocol::HashMap<int, std::unique_ptr<V8ConsoleMe ssageStorage>>;

120 ConsoleStorageMap m_consoleStorageMap;	121 ConsoleStorageMap m_consoleStorageMap;

121 };	122 };

122	123

123 } // namespace v8_inspector	124 } // namespace v8_inspector

124	125

125	126

126 #endif // V8InspectorImpl_h	127 #endif // V8InspectorImpl_h

OLD	NEW