third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector-protocol/runtime/runtime-runScript-async-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html

diff --git a/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html b/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html

index c1f46a4706c2b1c14f9e009078b8809482097179..726c3a3345daf8829074d984d15d7b8ca944fddf 100644

--- a/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html

+++ b/third_party/WebKit/LayoutTests/inspector-protocol/worker/exception-from-worker-contains-stack.html

@@ -53,7 +53,7 @@ function test()

{

var message = JSON.parse(messageObject["params"]["message"]);

if (message["method"] === "Runtime.exceptionThrown") {

- var callFrames = message.params.details.stackTrace ? message.params.details.stackTrace.callFrames : [];

+ var callFrames = message.params.exceptionDetails.stackTrace ? message.params.exceptionDetails.stackTrace.callFrames : [];

InspectorTest.log(callFrames.length > 0 ? "Message with stack trace received." : "[FAIL] Message contains empty stack trace");

messageReceived = true;

if (messageReceived && workerTerminated)