third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

diff --git a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

index 15d23ff089afbc8e939ec2b986e3800213c35aca..c8f56c526e4d6dd34e1732dc3d2b40e8d7a2b066 100644

--- a/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

+++ b/third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

@@ -7,8 +7,11 @@ var test = function()

{

function printExceptionDetails(exceptionDetails)

{

- InspectorTest.addResult("exceptionDetails:")

- InspectorTest.addResult(" " + exceptionDetails.text);

+ InspectorTest.addResult("exceptionDetails:");

+ var text = exceptionDetails.text;

+ if (exceptionDetails.exception)

+ text += " " + exceptionDetails.exception.description;

+ InspectorTest.addResult(" " + text);

InspectorTest.addResult(" line: " + exceptionDetails.lineNumber + ", column: " + exceptionDetails.columnNumber);

var stack = exceptionDetails.stackTrace ? exceptionDetails.stackTrace.callFrames : null;