Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4490)

Unified Diff: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
diff --git a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
index c0c65505e522aef830ab6b16686905af28799053..58acb6351d9ac5ced5d008989239901f6bbe520b 100644
--- a/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
+++ b/chrome/test/data/extensions/api_test/uncaught_exception_logging/test.js
@@ -6,7 +6,8 @@ function createTestFunction(expected_message) {
return function(tab) {
function onDebuggerEvent(debuggee, method, params) {
if (debuggee.tabId == tab.id && method == 'Runtime.exceptionThrown') {
- if (params.exception.value.indexOf(expected_message) > -1) {
+ var exception = params.exceptionDetails.exception;
+ if (exception.value.indexOf(expected_message) > -1) {
chrome.debugger.onEvent.removeListener(onDebuggerEvent);
chrome.test.succeed();
}
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector-protocol/console/console-let-const-with-api.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698