Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: third_party/WebKit/Source/platform/v8_inspector/V8Debugger.cpp

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: browser test Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "platform/v8_inspector/V8Debugger.h" 5 #include "platform/v8_inspector/V8Debugger.h"
6 6
7 #include "platform/v8_inspector/DebuggerScript.h" 7 #include "platform/v8_inspector/DebuggerScript.h"
8 #include "platform/v8_inspector/ScriptBreakpoint.h" 8 #include "platform/v8_inspector/ScriptBreakpoint.h"
9 #include "platform/v8_inspector/V8Compat.h" 9 #include "platform/v8_inspector/V8Compat.h"
10 #include "platform/v8_inspector/V8DebuggerAgentImpl.h" 10 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
357 if (!dryRun && isPaused()) { 357 if (!dryRun && isPaused()) {
358 JavaScriptCallFrames frames = currentCallFrames(); 358 JavaScriptCallFrames frames = currentCallFrames();
359 newCallFrames->swap(frames); 359 newCallFrames->swap(frames);
360 } 360 }
361 return true; 361 return true;
362 } 362 }
363 // Compile error. 363 // Compile error.
364 case 1: 364 case 1:
365 { 365 {
366 *exceptionDetails = protocol::Runtime::ExceptionDetails::create() 366 *exceptionDetails = protocol::Runtime::ExceptionDetails::create()
367 .setExceptionId(m_inspector->nextExceptionId())
367 .setText(toProtocolStringWithTypeCheck(resultTuple->Get(2))) 368 .setText(toProtocolStringWithTypeCheck(resultTuple->Get(2)))
368 .setScriptId(String16("0"))
369 .setLineNumber(resultTuple->Get(3)->ToInteger(m_isolate)->Value( ) - 1) 369 .setLineNumber(resultTuple->Get(3)->ToInteger(m_isolate)->Value( ) - 1)
370 .setColumnNumber(resultTuple->Get(4)->ToInteger(m_isolate)->Valu e() - 1).build(); 370 .setColumnNumber(resultTuple->Get(4)->ToInteger(m_isolate)->Valu e() - 1).build();
371 return false; 371 return false;
372 } 372 }
373 } 373 }
374 *error = "Unknown error."; 374 *error = "Unknown error.";
375 return false; 375 return false;
376 } 376 }
377 377
378 JavaScriptCallFrames V8Debugger::currentCallFrames(int limit) 378 JavaScriptCallFrames V8Debugger::currentCallFrames(int limit)
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
830 return nullptr; 830 return nullptr;
831 831
832 size_t stackSize = fullStack ? V8StackTraceImpl::maxCallStackSizeToCapture : 1; 832 size_t stackSize = fullStack ? V8StackTraceImpl::maxCallStackSizeToCapture : 1;
833 if (m_inspector->enabledRuntimeAgentForGroup(contextGroupId)) 833 if (m_inspector->enabledRuntimeAgentForGroup(contextGroupId))
834 stackSize = V8StackTraceImpl::maxCallStackSizeToCapture; 834 stackSize = V8StackTraceImpl::maxCallStackSizeToCapture;
835 835
836 return V8StackTraceImpl::capture(this, contextGroupId, stackSize); 836 return V8StackTraceImpl::capture(this, contextGroupId, stackSize);
837 } 837 }
838 838
839 } // namespace v8_inspector 839 } // namespace v8_inspector
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698