third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html - Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run.html

Issue 2249743006: [DevTools] Fill ExceptionDetails with more details, unify usage across protocol. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: browser test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/sources/debugger-pause/debugger-eval-while-paused-throws-expected.txt ('k') | third_party/WebKit/LayoutTests/inspector/sources/debugger/debugger-compile-and-run-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <html>	1 <html>

2 <head>	2 <head>

3 <script src="../../../http/tests/inspector/inspector-test.js"></script>	3 <script src="../../../http/tests/inspector/inspector-test.js"></script>

4 <script src="../../../http/tests/inspector/debugger-test.js"></script>	4 <script src="../../../http/tests/inspector/debugger-test.js"></script>

5 <script>	5 <script>

6 var test = function()	6 var test = function()

7 {	7 {

8 function printExceptionDetails(exceptionDetails)	8 function printExceptionDetails(exceptionDetails)

9 {	9 {

10 InspectorTest.addResult("exceptionDetails:")	10 InspectorTest.addResult("exceptionDetails:");

11 InspectorTest.addResult(" " + exceptionDetails.text);	11 var text = exceptionDetails.text;

	12 if (exceptionDetails.exception)

	13 text += " " + exceptionDetails.exception.description;

	14 InspectorTest.addResult(" " + text);

12 InspectorTest.addResult(" line: " + exceptionDetails.lineNumber + ", c olumn: " + exceptionDetails.columnNumber);	15 InspectorTest.addResult(" line: " + exceptionDetails.lineNumber + ", c olumn: " + exceptionDetails.columnNumber);

13	16

14 var stack = exceptionDetails.stackTrace ? exceptionDetails.stackTrace.ca llFrames : null;	17 var stack = exceptionDetails.stackTrace ? exceptionDetails.stackTrace.ca llFrames : null;

15 if (!stack) {	18 if (!stack) {

16 InspectorTest.addResult(" no stack trace attached to exceptionDeta ils");	19 InspectorTest.addResult(" no stack trace attached to exceptionDeta ils");

17 } else {	20 } else {

18 InspectorTest.addResult(" exceptionDetails stack trace:");	21 InspectorTest.addResult(" exceptionDetails stack trace:");

19 for (var i = 0; i < stack.length && i < 100; ++i) {	22 for (var i = 0; i < stack.length && i < 100; ++i) {

20 InspectorTest.addResult(" url: " + stack[i].url);	23 InspectorTest.addResult(" url: " + stack[i].url);

21 InspectorTest.addResult(" function: " + stack[i].functionN ame);	24 InspectorTest.addResult(" function: " + stack[i].functionN ame);

(...skipping 69 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
91 }	94 }

92 ]);	95 ]);

93 }	96 }

94 </script>	97 </script>

95 </head>	98 </head>

96 <body onload="runTest()">	99 <body onload="runTest()">

97 <p>Tests separate compilation and run.</p>	100 <p>Tests separate compilation and run.</p>

98 <a href="https://bugs.webkit.org/show_bug.cgi?id=89646">Bug 89646.</a>	101 <a href="https://bugs.webkit.org/show_bug.cgi?id=89646">Bug 89646.</a>

99 </body>	102 </body>

100 </html>	103 </html>

OLD	NEW